refactor!: remove v3 binary-compatibility shims for TUnit#372
Merged
Conversation
TUnit no longer depends on EnumerableAsyncProcessor, so the members kept solely so TUnit.Engine (compiled against v3) could bind at runtime are no longer needed: - Remove redundant ProcessInParallel(int maxConcurrency) shims from the four builder classes; int arguments still resolve to the ProcessInParallel(int?, bool) overload. - Remove the obsolete no-selector AsyncEnumerableExtensions.ProcessInParallel<T>(IAsyncEnumerable<T>, CancellationToken) collect-only overload. - Delete V3BinaryCompatibilityTests and the corresponding PublicAPI.Shipped.txt entries (v4 is not yet tagged, so the surface never shipped). - Drop the TUnit coupling notes from CLAUDE.md and the README migration guide.
Greptile SummaryThis PR removes pre-v4 binary-compatibility shims from the public API. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "refactor!: remove v3 binary-compatibilit..." | Re-trigger Greptile |
thomhurst
enabled auto-merge (squash)
July 21, 2026 23:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TUnit no longer depends on EnumerableAsyncProcessor, so the v3 binary-compatibility shims kept for TUnit.Engine can go before v4 ships.
ProcessInParallel(int maxConcurrency)shims fromActionAsyncProcessorBuilder,ActionAsyncProcessorBuilder<TOutput>,ItemActionAsyncProcessorBuilder<TInput>, andItemActionAsyncProcessorBuilder<TInput, TOutput>. Callers passing anintstill compile via the implicit conversion to theProcessInParallel(int?, bool)overload.AsyncEnumerableExtensions.ProcessInParallel<T>(IAsyncEnumerable<T>, CancellationToken)overload, which only collected the stream into a list.V3BinaryCompatibilityTestsand the five matchingPublicAPI.Shipped.txtentries (v4 is untagged, so this surface was never actually shipped).Test plan
dotnet build— clean, no new warningsdotnet test— 1716 tests pass across net8.0/net9.0/net10.0; test discovery succeeds, confirming TUnit.Engine no longer binds the removed members